Fix: Make sure every TinyDB index db instance is closed #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randombenj
reviewed
Jan 4, 2023
| @@ -406,8 +406,8 @@ def test_index_all_projects_creates_file_and_version_index_api(client_with_claim | |||
|
|
|||
| for project in projects: | |||
| for version in versions: | |||
| mock_insert_version_into_version_index.assert_any_call(docat.DOCAT_INDEX_PATH, project, version, []) | |||
| mock_insert_file_index_into_db.assert_any_call(docat.DOCAT_INDEX_PATH, project, version, "index.html", "hello world") | |||
| mock_insert_version_into_version_index.assert_any_call(ANY, project, version, []) | |||
There was a problem hiding this comment.
Because I changed the parameter from the index db path to the actual db instance. I then passed in docat.index_db but the test failed all the time because it thought the two instances were different somehow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The index db connection is now generated in app.py and passed to the utils.