-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/13-implement-search #320
Conversation
I guess we need to rethink how we do things im not a fan of how many things one needs to configure
|
I know it's not nice but we need to save the index somehow because indexing is really expensive. What we could do is just provide one DB_PATH variable that is used for both databases. |
54b638c
to
b3d5bd8
Compare
b3d5bd8
to
cfe32c9
Compare
cfe32c9
to
c77c796
Compare
c77c796
to
ae3c745
Compare
ae3c745
to
d4ff2d2
Compare
@fliiiix
|
66c8f8e
to
1fa2a21
Compare
1fa2a21
to
b773b92
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Added my review for the backend, the frontend won't be reviewed as it will be refactored by @reglim anyway. |
fb87125
to
6ba0f62
Compare
6bc6e80
to
6c59504
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The python part looks good to me, shall we merge and you rebase or shall we first merge the react migration?
We can merge, but first I think I'd remove the web part. |
6c59504
to
dc209d3
Compare
dc209d3
to
472f44f
Compare
472f44f
to
827e469
Compare
@randombenj It'd be nice if you could just glance over it just to make sure everything's fixed. I removed the web part and sqashed everything. |
Also, when we release this, we need to communicate clearly, that the DOCAT_DOC_PATH is no longer used and replaced with DOCAT_STORAGE_PATH / doc. When you use the docker container, this is still the same, but locally it's not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the nice changes!
We can do the breaking changes announcement once we release.
@reglim & @randombenj lets talk about the release timeline next week also nice work @reglim ✨ |
I created an index database that gets updated at every modification and is used to speed up searching projects, versions, tags and content. I also added the actual search page itself and a search bar in the header.
Can someone please verify that the docker pass-through for the index.json database should work? I don't have much experience with that.
fixes #13