Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(web): Help Page shown before projects are loaded #295

Merged

Conversation

reglim
Copy link
Contributor

@reglim reglim commented Oct 3, 2022

It is still shown when no projects are present

fixes: #294

@fliiiix
Copy link
Member

fliiiix commented Oct 3, 2022

is there really not better solution to this? it seems like a common problem to me

It is still shown when no projects are present

fixes: #294
@reglim reglim force-pushed the bugfix/294-Help-Page-Shown-Before-Projects-are-loaded branch from bd030be to 3ffc344 Compare October 3, 2022 11:20
@reglim
Copy link
Contributor Author

reglim commented Oct 3, 2022

Ok, so I set projects to null by default and changed the check for whether or not to show the help page to <Help v-if="projects?.length === 0" />

@randombenj randombenj merged commit 6b1b04d into main Oct 3, 2022
@reglim reglim deleted the bugfix/294-Help-Page-Shown-Before-Projects-are-loaded branch October 4, 2022 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Help Page shown before projects are loaded
3 participants