Leon/tapir issue 18/modern terminology #22
Conversation
WalkthroughThe pull request introduces a comprehensive terminology update across multiple files, replacing words like "whitelist", "blacklist", and "greylist" with "allowlist", "denylist", and "doubtlist", respectively. The changes span several Go files, including Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (2)
cmd/debug.go (1)
329-329: Use time.Since instead of time.Now().Sub.Replace
time.Now().Subwithtime.Sincefor better readability and idiomatic Go.Apply this diff:
- ttl := n.TTL - time.Now().Sub(n.TimeAdded).Round(time.Second) + ttl := n.TTL - time.Since(n.TimeAdded).Round(time.Second)🧰 Tools
🪛 golangci-lint (1.62.2)
329-329: S1012: should use
time.Sinceinstead oftime.Now().Sub(gosimple)
structs.go (1)
351-352: Consider updating the comment format.While the terminology update is correct, the comment format could be improved.
Apply this diff to improve the comment format:
- // doubtlist sources needs more complex stuff here: - // DoubtNames map[string]DoubtName + // Doubtlist sources need more complex configuration: + // DoubtNames map[string]DoubtName
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
bitmask.go(3 hunks)cmd/debug.go(9 hunks)cmd/filterlists.go(1 hunks)cmd/mqtt.go(8 hunks)cmd/rpz.go(2 hunks)structs.go(5 hunks)
🧰 Additional context used
🪛 golangci-lint (1.62.2)
cmd/debug.go
69-69: printf: fmt.Printf format %d has arg resp.DenylistedNames of wrong type map[string]bool
(govet)
70-70: printf: fmt.Printf format %d has arg resp.DoubtlistedNames of wrong type map[string]*github.com/dnstapir/tapir.TapirName
(govet)
329-329: S1012: should use time.Since instead of time.Now().Sub
(gosimple)
cmd/mqtt.go
36-36: var defaulttopic is unused
(unused)
🔇 Additional comments (10)
cmd/filterlists.go (1)
12-14: LGTM! Command renamed appropriately.The command has been correctly renamed from
ColourlistsCmdtoFilterlistsCmdwith updated terminology in the description.bitmask.go (1)
99-99: LGTM! Consistent terminology updates.The changes correctly update the terminology:
- Renamed constant from
WHITELISTtoALLOWLIST- Updated
StringToActionfunction to handle "allowlist"- Updated maps with new terminology
Also applies to: 108-109, 128-128, 136-136
cmd/rpz.go (1)
38-38: LGTM! Error messages and flag descriptions updated.The error messages and flag descriptions have been consistently updated with the new terminology.
Also applies to: 134-134
cmd/debug.go (1)
58-58: LGTM! Consistent terminology updates.All command names, descriptions, and messages have been updated to use the new terminology consistently.
Also applies to: 103-120, 204-206, 272-274, 277-282, 300-304, 321-323, 335-336, 341-341, 356-356, 362-362
structs.go (2)
243-243: LGTM! Consistent terminology update.The field descriptions in both
TapirMsgandWBGliststructs have been updated to use the new terminology consistently.Also applies to: 341-341
151-155: Verify consistent usage of renamed fields.The field renames align with the new terminology. However, we should verify that all references to these fields are updated consistently across the codebase.
✅ Verification successful
Field renames are consistently applied across the codebase
The verification confirms that all references to these fields use the new terminology ("allowlist", "denylist", "doubtlist") consistently. No instances of the old terminology were found, and the new field names are properly used throughout the codebase.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Search for any remaining references to the old field names. # This helps ensure we haven't missed any usage of the old terminology. echo "Searching for old field references..." rg -i "whitelist|blacklist|greylist" --type goLength of output: 133
Script:
#!/bin/bash # Search for new terminology usage echo "=== Searching for new terminology ===" rg -i "allowlist|denylist|doubtlist" --type go echo -e "\n=== Checking struct field access ===" # Look for struct field access patterns ast-grep --pattern 'struct { $$$ Allowlists $$$ Denylists $$$ Doubtlists $$$ DenylistedNames $$$ DoubtlistedNames $$$ $$$ }'Length of output: 5369
cmd/mqtt.go (4)
443-443: LGTM! Consistent terminology update.The
ListTypefield is consistently set to "doubtlist" in both instances.Also applies to: 546-546
742-742: LGTM! Command description and error handling updated.The command description and error handling have been updated to use the new terminology consistently.
Also applies to: 752-752, 760-760
835-835: LGTM! API request handling updated.The API request handling has been updated to use the new terminology consistently in both the request and error messages.
Also applies to: 845-845, 852-852, 856-856
780-780: LGTM! Flag description updated.The flag description and error message have been updated to use the new terminology consistently.
Also applies to: 788-788
I ended up replacing "grey" with "doubt"
Fix #18
Summary by CodeRabbit
Release Notes
Terminology Update
Command Updates
Structural Changes