Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kiwi: Compensate for page zoom in resize messages from/to JavaScript. #1370

Merged
merged 2 commits into from
Jan 22, 2015

Conversation

drinkcat
Copy link
Collaborator

Later on, we could add an option to actually obey the zoom settings.

Needs testing on a HiDPI device (Pixel).

Fixes #1295.

Later on, we could add an option to actually obey the zoom
settings.

Fixes dnschneid#1295.
@drinkcat drinkcat added the bug label Jan 22, 2015
@dnschneid
Copy link
Owner

No good on Pixel. Display only works (non-black) if I enable hi-dpi mode and system-zoom out to native resolution.

@dnschneid
Copy link
Owner

OK so now it's improved, but it doesn't display anything on first launch (you have to resize the window).
Also, hi-dpi mode plus system scaling results in double scaling, so if you enable hi-dpi mode then system scale to pixel-exact, you get a ridiculous resolution.

@drinkcat
Copy link
Collaborator Author

OK so now it's improved, but it doesn't display anything on first launch (you have to resize the window).

Can't reproduce on peppy... Is it happening with normal system scaling? Both with hi-dpi enabled and disabled?

Can you post the first few lines of console log? Maybe I can spot the problem.....

@drinkcat
Copy link
Collaborator Author

Also, hi-dpi mode plus system scaling results in double scaling, so if you enable hi-dpi mode then system scale to pixel-exact, you get a ridiculous resolution.

Let's track this in #1322...

@dnschneid
Copy link
Owner

Having trouble reproducing it myself now. I'm inclined to merge this as-is and try and figure out a solution to #1322 separately, since #1295 needs to be fixed.

dnschneid added a commit that referenced this pull request Jan 22, 2015
kiwi: Compensate for page zoom in resize messages from/to JavaScript.
@dnschneid dnschneid merged commit 4c69f84 into dnschneid:master Jan 22, 2015
@drinkcat drinkcat deleted the kiwi-fix-zoom branch January 22, 2015 19:37
@DennisLfromGA
Copy link
Collaborator

OK so now it's improved, but it doesn't display anything on first launch (you have to resize the window).

Hope this is not too 'irrelephant' but my HP Chromebook 14 requires resizing before the desktop display appears on both gnome & kde. I've just learned to live with it thinking that it'll get fixed at some point.

crouton: version 1-20150121180918~master:bd441b90
release: trusty
architecture: amd64
targets: xiwi,xorg,gnome,gnome-desktop,kde,kde-desktop,cli-extra,gtk-extra,chrome-beta
host: version 6457.68.0 (Official Build) beta-channel falco

@dnschneid
Copy link
Owner

OK, let's file a new bug for that then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xiwi: page zoom results in black screen
3 participants