Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/dns #18

Merged
merged 6 commits into from
Jul 2, 2022
Merged

Feature/dns #18

merged 6 commits into from
Jul 2, 2022

Conversation

dnnrly
Copy link
Owner

@dnnrly dnnrly commented Jul 1, 2022

Description

Add DNS waiting

Fixes #17

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Running existing tests
  • Created new tests

Checklist:

  • My code has been linted (make lint)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes (make test lint build acceptance-test)
  • I have rebased my branch to include the latest changes from master

@ghost
Copy link

ghost commented Jul 1, 2022

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #18 (3a70ab4) into main (69ae218) will increase coverage by 2.87%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
+ Coverage   85.71%   88.59%   +2.87%     
==========================================
  Files           2        2              
  Lines         119      149      +30     
==========================================
+ Hits          102      132      +30     
  Misses         15       15              
  Partials        2        2              
Impacted Files Coverage Δ
config.go 100.00% <100.00%> (ø)
waitfor.go 84.11% <100.00%> (+4.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69ae218...3a70ab4. Read the comment docs.

@dnnrly dnnrly merged commit 751e498 into main Jul 2, 2022
@dnnrly dnnrly deleted the feature/dns branch July 2, 2022 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add DNS resolution change
1 participant