Adds DefaultSvgTheme #964
Merged
Adds DefaultSvgTheme #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GP4cK
commented
Jul 12, 2023
| @@ -3,13 +3,14 @@ import 'dart:convert' show utf8; | |||
| import 'package:flutter/foundation.dart' hide compute; | |||
| import 'package:flutter/services.dart'; | |||
| import 'package:flutter/widgets.dart'; | |||
| import 'package:flutter_svg/src/utilities/http.dart'; | |||
There was a problem hiding this comment.
I read somewhere that it's not good to mix relative and absolute imports so I changed it to be more consistent.
That gets done to avoid exporting types from vector_graphics_compiler to end users from this library. |
dnfield
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #953
Some notes/questions:
DefaultSvgThemefrom v1.1.6fontSizebeing based on theDefaultTextStylebecause of this commentSvgThemeinflutter_svg/lib/src/loaders.dartseems to duplicate the one fromvector_graphics_compiler. Shouldn't we use only the one fromvector_graphics_compiler?