Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply image transform before translate and scale #790

Merged
merged 4 commits into from
Oct 25, 2022

Conversation

FeodorFitsner
Copy link
Contributor

Fix #788

Copy link
Owner

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense - can you add a test?

@FeodorFitsner
Copy link
Contributor Author

Sure, will give a try. Thanks for looking into that!

@FeodorFitsner
Copy link
Contributor Author

Just added a "golden" test. Is it what you are asking for? I'm not sure why CI is failing with so many failed tests - I did a trivial change. Am I doing something wrong?

@FeodorFitsner
Copy link
Contributor Author

@dnfield Could you please tell me what's wrong with the tests in this PR? I'm really confused as the PR should be affecting DrawableRasterImage() method only.

@dnfield
Copy link
Owner

dnfield commented Oct 25, 2022

the existing image.svg file has a transform on it that I guess wasn't correctly getting applied (does a translate(1, 1)). It will have to be updated for this change.

@FeodorFitsner
Copy link
Contributor Author

Alright, here you are!

Are you planning to do a release with these fixes anytime soon? I'd really love to have these changes in the upstream as I'm working on a package that depends on flutter_svg (it's easily crunching SVGs produced by Matplotlib and Plotly!) and "git" dependencies are not allowed in packages.

@dnfield dnfield merged commit d43b6b8 into dnfield:master Oct 25, 2022
@dnfield
Copy link
Owner

dnfield commented Oct 25, 2022

Very cool! I'll try to cut a release soon.

@dnfield
Copy link
Owner

dnfield commented Oct 25, 2022

Published in 1.1.6

@FeodorFitsner
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Raster image displaced when transform applied
2 participants