-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply image transform before translate and scale #790
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense - can you add a test?
Sure, will give a try. Thanks for looking into that! |
Just added a "golden" test. Is it what you are asking for? I'm not sure why CI is failing with so many failed tests - I did a trivial change. Am I doing something wrong? |
@dnfield Could you please tell me what's wrong with the tests in this PR? I'm really confused as the PR should be affecting |
the existing |
Alright, here you are! Are you planning to do a release with these fixes anytime soon? I'd really love to have these changes in the upstream as I'm working on a package that depends on |
Very cool! I'll try to cut a release soon. |
Published in 1.1.6 |
Thank you! |
Fix #788