-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Field.PostalCodeAndCity): add Norwegian postal code validator #4202
Draft
langz
wants to merge
4
commits into
main
Choose a base branch
from
feat/postal-code-validator
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
langz
changed the title
feat(PostalCodeAndCity): adds norwegian postal code validator
feat(Field.PostalCodeAndCity): adds norwegian postal code validator
Oct 30, 2024
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
langz
force-pushed
the
feat/postal-code-validator
branch
from
October 31, 2024 08:32
f7c28df
to
b68bffd
Compare
langz
force-pushed
the
feat/postal-code-validator
branch
2 times, most recently
from
October 31, 2024 09:49
cd462d5
to
41980cc
Compare
langz
force-pushed
the
feat/postal-code-validator
branch
from
October 31, 2024 10:17
41980cc
to
358b183
Compare
langz
commented
Oct 31, 2024
...ign-system-portal/src/docs/uilib/extensions/forms/feature-fields/PostalCodeAndCity/demos.mdx
Outdated
Show resolved
Hide resolved
langz
commented
Oct 31, 2024
packages/dnb-eufemia/src/extensions/forms/Field/PostalCodeAndCity/PostalCodeAndCity.tsx
Outdated
Show resolved
Hide resolved
langz
commented
Oct 31, 2024
packages/dnb-eufemia/src/extensions/forms/Field/PostalCodeAndCity/PostalCodeAndCityDocs.ts
Outdated
Show resolved
Hide resolved
…ity/PostalCodeAndCity.tsx
…rms/feature-fields/PostalCodeAndCity/demos.mdx
…ity/PostalCodeAndCityDocs.ts
langz
changed the title
feat(Field.PostalCodeAndCity): adds norwegian postal code validator
feat(Field.PostalCodeAndCity): add Norwegian postal code validator
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds norwegian postal code validator, and adds error messages that's more inline of the error messages used in
Field.BankAccountNumber
,Field.OrganizationNumber
,Field.NationalIdentityNumber
, etc.TODO:
validator
pattern
andvalidator
is colliding now for Norway