Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Field.PostalCodeAndCity): add Norwegian postal code validator #4202

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

langz
Copy link
Contributor

@langz langz commented Oct 30, 2024

This PR adds norwegian postal code validator, and adds error messages that's more inline of the error messages used in Field.BankAccountNumber, Field.OrganizationNumber, Field.NationalIdentityNumber, etc.

TODO:

  • Test it
  • Test how to override the validator
  • Test how if not pattern and validator is colliding now for Norway
  • Add unit tests
  • Probably minor updates to docs

Copy link

vercel bot commented Oct 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 10:48am

@langz langz changed the title feat(PostalCodeAndCity): adds norwegian postal code validator feat(Field.PostalCodeAndCity): adds norwegian postal code validator Oct 30, 2024
Copy link

codesandbox-ci bot commented Oct 30, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@langz langz changed the title feat(Field.PostalCodeAndCity): adds norwegian postal code validator feat(Field.PostalCodeAndCity): add Norwegian postal code validator Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant