-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Table): add Th
(header) width attribute for tables with fixed
layout
#3590
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Th
(header) width attribute support for fixed
ta…Th
(header) width attribute support for fixed
tables
Th
(header) width attribute support for fixed
tablesTh
(header) width attribute for fixed
tables
Th
(header) width attribute for fixed
tablesTh
(header) width attribute for tables with fixed
layout
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
1b0e2d3
to
019f695
Compare
019f695
to
d22ba70
Compare
Turns out the We might have to use css Also, we can avoid the small width change on expand if we leave 1 column to be "free". Since there is a hidden column for the expand icon, the total widths adds up to more than 100%, and we can't predict the percentage. But if one column doesn't have a width, it will fill the rest. Basically, any total width above 100% seems to be handled like a non-fixed table, so it changes when expanding. Though we should probably change the example to be more useful. Most real tables will have at least one column that can be flexible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use css width style
instead, as that supports more units and isn't deprecated.
No description provided.