forked from hypermodeinc/dgraph
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Shutdown extra connections (hypermodeinc#3280)
There is a race condition which allows multiple goroutines to cause connections to be created to other servers via `conn.Connect`. We only store one and the rest just get dropped on the floor. However, they are still ticking and causing pings to the other servers. In a recent incident, we saw thousands of `MonitorHealth` goroutines, which is obviously a huge drain on resources. This PR shuts down any connection which doesn't make it to the map, releasing resources correctly. Tested on live cluster.
1 parent
c321aa1
commit 49b1469
Showing
1 changed file
with
34 additions
and
18 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters