feat: new methods setDate / getDate

[flaviendelangle]

Alternative names: getDayInMonth / setDayInMonth (can be confusing with getDaysInMonth)

[dmtrKovalenko]

Please make sure that CI passes

[codecov-commenter]

Codecov Report

Merging #625 (6d5b8b6) into master (b39210e) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #625   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           16        16           
  Lines         1498      1536   +38     
  Branches       195       195           
=========================================
+ Hits          1498      1536   +38     

Impacted Files	Coverage Δ
...kages/date-fns-jalali/src/date-fns-jalali-utils.ts	100.00% <100.00%> (ø)
packages/date-fns/src/date-fns-utils.ts	100.00% <100.00%> (ø)
packages/dayjs/src/dayjs-utils.ts	100.00% <100.00%> (ø)
packages/hijri/src/hijri-utils.ts	100.00% <100.00%> (ø)
packages/jalaali/src/jalaali-utils.ts	100.00% <100.00%> (ø)
packages/js-joda/src/js-joda-utils.ts	100.00% <100.00%> (ø)
packages/luxon/src/luxon-utils.ts	100.00% <100.00%> (ø)
packages/moment/src/moment-utils.ts	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[flaviendelangle]

I feel like Codecov is 1 commit behind
Yesterday I pushed 1 commit with 3-4 lines of code uncovered => no report, just the CI fail
This morning I pushed 1 commit to fix with 0 lines of code uncovered => report saying I have 3-4 lines of code uncovered
Just now I pushed 1 empty commit => report saying I have 0 lines of code uncovered

[dmtrKovalenko]

WDYT about making it getDay. I think it is more clear in terms of Date is the term for javascript date and may be confusing that it returns a number.

[dmtrKovalenko]

Yes getDayInMonths or simply getDay would be fine. Everything else is great, so once you will done the rename – we can merge

[flaviendelangle]

I based my naming on the javascript Date interface

new Date().getDay() => the day in the week
new Date().getDate() => the day in the month

But I don't have a strong opinion here
Libraries are not even coherent between them.

[flaviendelangle]

@dmtrKovalenko