RFC - extend from \yii\console\controllers\MigrateController #9
Conversation
…rateController and use json encoded array instead of migration name
|
That sounds awesome. The reason for the code duplication is here btw: yiisoft/yii2#3273 I made the PR, it was open for months and someone did a huge refactoring of the console controllers. But your PR is not backward compatible, since the old schema is used, just with a different migration name, right ... Is this going to Yii 2 core? |
|
I think the biggest problem here is when trying to use a different type for migration names than string. This forces to overide most of the methods and actions. That's why I just used JSON. I did use the new schema with the alias column, but it's not required. And it could detect if the string is valid JSON or not and use the default migrationPath. I'm not sure this fits into the core. If it would, I'd refactor the core controller to allow using a full object instead of this JSON string. |
|
After a while I gave this a try, but it did not recognize multiple paths specified in There is still an open issue on yiisoft/yii2#384 about this feature. @nineinchnick Any thoughts about how to continue? |
|
What params are you referring to? I'm using my fork in production (https://github.com/nineinchnick/yii2-migrate-command). I just configure the migrationLookup property of the migrate command to include all my modules. |
|
See the README |
|
It seems it's only mentioned in the readme and not used anywhere in the code. |
|
I've updated the PR and added code handling that app param. |
Extending from core MigrateController allows easier upgrading of this extension and avoids code duplication.
Because core controller assumes migration names are strings, I've encoded it into JSON to add the alias. This looks ugly when printing names, but works.
This PR can be closed, it's just a proof of concept.