[CI] Improve CI for Mac M1 #9748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
hcho3
commented
Nov 1, 2023
hcho3
commented
- Don't create Conda env
- Build XGBoost4J lib
trivialfis
reviewed
Nov 1, 2023
| @@ -32,6 +32,9 @@ elseif(CMAKE_CXX_COMPILER_ID STREQUAL "Clang") | |||
| message(FATAL_ERROR "Need Clang 9.0 or newer to build XGBoost") | |||
| endif() | |||
| endif() | |||
| if(APPLE) | |||
| set(CMAKE_MACOSX_DEPLOYMENT_TARGET 10.15) | |||
There was a problem hiding this comment.
Is it possible to use this as an independent command line argument in CI instead of hardcoding it into the source code?
There was a problem hiding this comment.
Sure, let me create a PR.
hcho3
added a commit
to hcho3/xgboost
that referenced
this pull request
Dec 14, 2023
* [CI] Improve CI for Mac M1 * Add -v flag * Disable OpenMP in libxgboost4j.dylib * Target MacOS 10.15+ to use C++17
hcho3
added a commit
that referenced
this pull request
Dec 14, 2023
razdoburdin
added a commit
to IntelPython/xgboost_oneapi
that referenced
this pull request
Dec 19, 2023
* [backport][sklearn] Fix loading model attributes. (dmlc#9808) (dmlc#9880) * [backport][py] Use the first found native library. (dmlc#9860) (dmlc#9879) * [backport] [CI] Upload libxgboost4j.dylib (M1) to S3 bucket (dmlc#9887) * [CI] Set up CI for Mac M1 (dmlc#9699) * [CI] Improve CI for Mac M1 (dmlc#9748) * [CI] Build libxgboost4j.dylib with CMAKE_OSX_DEPLOYMENT_TARGET (dmlc#9749) * [CI] Upload libxgboost4j.dylib (M1) to S3 bucket (dmlc#9886) * [jvm-packages] Fix POM for xgboost-jvm metapackage (dmlc#9893) * [jvm-packages] Fix POM for xgboost-jvm metapackage * Add script for updating the Scala version * Bump version to 2.0.3 (dmlc#9895) * Update change_scala_version.py to also change scala.version property (dmlc#9897) --------- Co-authored-by: Jiaming Yuan <[email protected]> Co-authored-by: Philip Hyunsu Cho <[email protected]>
razdoburdin
added a commit
to IntelPython/xgboost_oneapi
that referenced
this pull request
May 15, 2024
* [backport][sklearn] Fix loading model attributes. (dmlc#9808) (dmlc#9880) * [backport][py] Use the first found native library. (dmlc#9860) (dmlc#9879) * [backport] [CI] Upload libxgboost4j.dylib (M1) to S3 bucket (dmlc#9887) * [CI] Set up CI for Mac M1 (dmlc#9699) * [CI] Improve CI for Mac M1 (dmlc#9748) * [CI] Build libxgboost4j.dylib with CMAKE_OSX_DEPLOYMENT_TARGET (dmlc#9749) * [CI] Upload libxgboost4j.dylib (M1) to S3 bucket (dmlc#9886) * [jvm-packages] Fix POM for xgboost-jvm metapackage (dmlc#9893) * [jvm-packages] Fix POM for xgboost-jvm metapackage * Add script for updating the Scala version * Bump version to 2.0.3 (dmlc#9895) * Update change_scala_version.py to also change scala.version property (dmlc#9897) * [backport] Fix compiling with the latest CTX. (dmlc#10263) --------- Co-authored-by: Jiaming Yuan <[email protected]> Co-authored-by: Philip Hyunsu Cho <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.