-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dask] Fix running on k8s. #6343
Conversation
* Avoid accessing `scheduler_info()['workers']`. * Avoid calling `client.gather` inside task. * Avoid using `client.scheduler_address`.
a270e38
to
93ca298
Compare
Hey @trivialfis , I'm really excited to see this! I have easy access to Dask clusters on EKS, so if you want me to test anything there I'd be happy to. |
@jameslamb Thanks for the offer! So far I managed to get some examples working on GKE. But automated pytest is not on the table since everything just times out while waiting for scheduling. Feel free to test it out, it might help uncovering some other unknown issues on xgboost and dask and be useful to others. Also the issue is not reproducible on local deployment, so they are cluster specific. Your tests are definitely gonna be helpful! I'm not sure about the performance impact and memory usage impact of current workaround, should be trivial even if there's any but I need to try it out. |
A refactoring is coming. |
Close #5765
socket
from Python.client.scheduler_info()['workers']
.client.gather
inside task function.XGBoost still cannot be run on GKE yet.See dask/dask#6800 for details.