Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to scikit-learn 1.6 estimator tag changes #11021

Merged
merged 15 commits into from
Dec 4, 2024
+181 −26
Merged

Adapt to scikit-learn 1.6 estimator tag changes #11021

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
79ed32c
add methods in XGBModel
jameslamb Nov 24, 2024
3106cf1
implement __sklearn_tags__()
jameslamb Nov 24, 2024
3af44be
regressor tests passing
jameslamb Nov 24, 2024
a9e30b4
Merge branch 'master' of github.com:dmlc/xgboost into python/support-…
jameslamb Nov 26, 2024
6a12576
centrallize more in _more_tags(), ignore testing outputs in .gitignore
jameslamb Nov 26, 2024
52e6d83
make get_params() check less fragile
jameslamb Nov 26, 2024
816667a
formatting
jameslamb Nov 26, 2024
abfc6a6
ignore pylint warning
jameslamb Nov 26, 2024
ef725c1
fix imports in environment without scikit-learn, fix tests
jameslamb Nov 26, 2024
d845922
address pylint warnings
jameslamb Nov 26, 2024
b7564a1
remove 'pylint: disable' comments for too-many-ancestors and too-few-…
jameslamb Nov 26, 2024
8364e92
Merge branch 'master' into python/support-scikit-learn-1.6
jameslamb Dec 1, 2024
a511848
rely on mixins to set estimator_type, removed unused imports
jameslamb Dec 1, 2024
27a1bcc
Merge branch 'master' into python/support-scikit-learn-1.6
jameslamb Dec 3, 2024
18c602f
check for get_params() instead
jameslamb Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Loading
Loading status checks…
ignore pylint warning
@jameslamb
jameslamb committed Nov 26, 2024
commit abfc6a6409ad2b508c5abc1c4bab61cd7efd0130
2 changes: 1 addition & 1 deletion python-package/xgboost/sklearn.py
View file
Original file line number Diff line number Diff line change
@@ -840,7 +840,7 @@ def __sklearn_tags__(self) -> _sklearn_Tags:
# take whatever tags are provided by BaseEstimator, then modify
# them with XGBoost-specific values
return self._update_sklearn_tags_from_dict(
tags=XGBModelBase.__sklearn_tags__(self),
tags=XGBModelBase.__sklearn_tags__(self), # pylint: disable=no-member
tags_dict=self._more_tags(),
)

Unchanged files with check annotations Beta

View file
tests/ci_build/Dockerfile.i386
FROM i386/debian:sid

Check warning on line 1 in tests/ci_build/Dockerfile.i386

GitHub Actions / Build 32-bit

Base image platform does not match expected target platform 

InvalidBaseImagePlatform: Base image i386/debian:sid was pulled with platform "linux/386", expected "linux/amd64" for current build
ENV DEBIAN_FRONTEND=noninteractive
SHELL ["/bin/bash", "-c"]