[R] Remove demos #10750
Merged
[R] Remove demos #10750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, could you please help remove the related CI tests as well? |
Removed. |
trivialfis
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #9810
ref #9734 (comment)
This PR removes the R package demos for XGBoost.
Reason being: it's uncommon nowadays for people to look at demos. XGBoost has vignettes , in-docs examples, and tutorials in the docs website; all of which are more likely to be read by users. Moreover, some of the functionalities in the demo have become outdated with the changes that XGBoost has implemented since they were written (e.g. it now has support for categorical features and data frames), and some of the demos have already been removed due to being broken (e.g. interaction with the library 'caret', which is deprecated already and not meant to be used).
It might be worth it in the future to add some of those back as additional snippets in vignettes, but given the limited manpower available, removing them is going to make progress on the R interface faster.