Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roadmap: MinGW build support (32/64-bit) #3436

Closed
2 of 4 tasks
hcho3 opened this issue Jul 4, 2018 · 6 comments
Closed
2 of 4 tasks

Roadmap: MinGW build support (32/64-bit) #3436

hcho3 opened this issue Jul 4, 2018 · 6 comments

Comments

@hcho3
Copy link
Collaborator

hcho3 commented Jul 4, 2018

There has been a report (e.g. #2958) reporting compilation failure with MinGW. This issue is intended to keep track of progress with regards to MinGW build support.

Currently, Windows CI tests (on AppVeyor) build XGBoost with MSYS-MinGW. Feel free to report any variant of MinGW that fails to build XGBoost.

@hcho3
Copy link
Collaborator Author

hcho3 commented Jul 4, 2018

@hcho3
Copy link
Collaborator Author

hcho3 commented Jul 4, 2018

@tqchen Quick search reveals to me that there are varieties of MinGW when it comes to handling fopen64. The R package solves this problem by bundling Windows R installation with a particular flavor of MinGW (see https://cran.r-project.org/bin/windows/Rtools/). Should we aim to support multiple flavors of MinGW?

@KOLANICH
Copy link
Contributor

KOLANICH commented Jul 4, 2018

Can you post the exact version and variant of the compiler you are using in issue #3436?

If I remember right, the version referenced by Theano: https://anaconda.org/msys2/m2w64-toolchain

But the most recent MinGW-w64 from the SourceForge (32 bit, https://sourceforge.net/projects/mingw-w64/files/Toolchains%20targetting%20Win32/Personal%20Builds/mingw-builds/8.1.0/threads-win32/sjlj/i686-8.1.0-release-win32-sjlj-rt_v6-rev0.7z ) neither works.

@hcho3
Copy link
Collaborator Author

hcho3 commented Jul 4, 2018

@KOLANICH Thanks a lot. Sorry again for massively closing issues. From now on, we'll try to keep the number of open issues small. All MinGW-related issues and works will be posted in this thread, so as to keep track of overall progress in MinGW support.

@KOLANICH
Copy link
Contributor

KOLANICH commented Jul 17, 2018

It is impossible to find out whichncompiler is used solely withnpreprocessor. So I have implemented a CMake solution and have thrown away old duct tape. Now if the definition is needed is determined by presence of the function.
dmlc/dmlc-core#432

If you dislike my solution, feell free to add commits above it or just rewrite the commit with the own one.

@hcho3
Copy link
Collaborator Author

hcho3 commented Sep 5, 2018

Closing this for now since dmlc/dmlc-core#432 has been merged.

@hcho3 hcho3 closed this as completed Sep 5, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Dec 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants