Skip to content

Fix NativeLibLoader on Java 9+ - #315

Merged
chyunsu3 merged 1 commit into
dmlc:mainlinefrom
guozhaochen:mainline
Sep 20, 2021
Merged

chyunsu3 merged 1 commit into
dmlc:mainlinefrom
guozhaochen:mainline

Conversation

@guozhaochen

Copy link
Copy Markdown
Contributor

Same issue as reported for XGBoost4j: dmlc/xgboost#4342
This fix copies the fix for xgboost4j: dmlc/xgboost#4351

Testing has been done on Java 11 and Java 17.

@codecov

codecov Bot commented Sep 19, 2021

Copy link
Copy Markdown

Codecov Report

Merging #315 (7a9150d) into mainline (80a7410) will decrease coverage by 0.11%.
The diff coverage is 50.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##             mainline     #315      +/-   ##
==============================================
- Coverage       85.15%   85.03%   -0.12%     
+ Complexity         46       43       -3     
==============================================
  Files             108      106       -2     
  Lines            8264     7219    -1045     
  Branches          471       40     -431     
==============================================
- Hits             7037     6139     -898     
+ Misses           1202     1056     -146     
+ Partials           25       24       -1     
Impacted Files Coverage Δ
.../java/ml/dmlc/treelite4j/java/NativeLibLoader.java 63.63% <50.00%> (+1.87%) ⬆️
python/treelite/libpath.py 75.00% <0.00%> (-7.15%) ⬇️
runtime/python/treelite_runtime/libpath.py 75.00% <0.00%> (-7.15%) ⬇️
src/frontend/xgboost/xgboost_json.h 83.07% <0.00%> (-6.14%) ⬇️
include/treelite/base.h 52.17% <0.00%> (-5.52%) ⬇️
include/treelite/typeinfo.h 85.18% <0.00%> (-4.82%) ⬇️
src/compiler/native/typeinfo_ctypes.h 43.47% <0.00%> (-4.53%) ⬇️
src/compiler/ast/ast.h 34.92% <0.00%> (-3.91%) ⬇️
src/gtil/predict.cc 81.81% <0.00%> (-3.69%) ⬇️
src/threading_utils/parallel_for.h 97.14% <0.00%> (-2.86%) ⬇️
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80a7410...7a9150d. Read the comment docs.

@chyunsu3
chyunsu3 merged commit 936a085 into dmlc:mainline Sep 20, 2021
@chyunsu3

Copy link
Copy Markdown
Collaborator

Thank you for your contribution!

@chyunsu3 chyunsu3 mentioned this pull request Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants