Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing broken links #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixing broken links #44

wants to merge 1 commit into from

Conversation

sandeep-krishnamurthy
Copy link

  • Fixing various broken links.

@mli
Copy link
Member

mli commented Mar 7, 2017

The reason that I used ./module.ipynb not mxnet.io/... because that link is clickable within notebook, say either you view on github or edit in notebook.

we should let the script located in mxnet/docs/ to automatically change these relative paths to the mxnet.io url, instead changing it manually in the notebooks

@sandeep-krishnamurthy
Copy link
Author

Hi Mu,
Can we merge these changes now and I will create issue to update build script to change relative paths and track in different task? I am worried about broken links are already live on mxnet.io for our readers and we received many complaints from customers (SAs).
Thanks,
Sandeep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sandeep-krishnamurthy @mli