Skip to content
This repository has been archived by the owner on Aug 11, 2020. It is now read-only.

add stride_x_ and stride_y_ for more flexible configuration #51

Merged
merged 3 commits into from
Sep 22, 2015
Merged

add stride_x_ and stride_y_ for more flexible configuration #51

merged 3 commits into from
Sep 22, 2015

Conversation

DrustZ
Copy link
Contributor

@DrustZ DrustZ commented Sep 21, 2015

pack and unpack function: replace stride with stride_x_ and stride_y_ for more flexible configuration without changing the origin method's interface

@antinucleon
Copy link
Contributor

Thanks for the PR! Please fix the lint in your PR

@tqchen
Copy link
Member

tqchen commented Sep 22, 2015

Please fix the lint checks here https://travis-ci.org/dmlc/mshadow/jobs/81417921

@DrustZ
Copy link
Contributor Author

DrustZ commented Sep 22, 2015

I fixed it.
BTW, could you please view my issue of #50 ?

@tqchen
Copy link
Member

tqchen commented Sep 22, 2015

There was a lint error https://travis-ci.org/dmlc/mshadow/jobs/81518522

You can reproduce this locally by running dmlc-core/scripts/lint.py

@DrustZ
Copy link
Contributor Author

DrustZ commented Sep 22, 2015

this time should work.

tqchen added a commit that referenced this pull request Sep 22, 2015
add stride_x_ and stride_y_ for more flexible configuration
@tqchen tqchen merged commit 7a3ccde into dmlc:master Sep 22, 2015
yajiedesign pushed a commit to yajiedesign/mshadow that referenced this pull request Oct 6, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants