This repository was archived by the owner on Jan 15, 2024. It is now read-only.
Merged
Conversation
Codecov Report
|
Codecov Report
@@ Coverage Diff @@
## v0.7.x #863 +/- ##
==========================================
- Coverage 90.43% 89.76% -0.68%
==========================================
Files 66 66
Lines 6348 6350 +2
==========================================
- Hits 5741 5700 -41
- Misses 607 650 +43
|
Confirmed that vocab[vocab.unknown_token] still == 0 for all models created prior to the flexible vocab PR. Ie: - book_corpus_wiki_en_uncased - wiki_multilingual_uncased - openwebtext_book_corpus_wiki_en_uncased - wiki_multilingual_cased - wiki_cn_cased
513e920 to
ddcda74
Compare
Fixed in master branch by dmlc#838 Fix does not apply here as it would require dropping py2.
980f689 to
883a34a
Compare
Member
|
This needs more fixing |
Test v0.7x branch only on v1.4 due to incompatible doctest output on both mxnet versions
9861def to
9fb7e32
Compare
Member
Member
|
Job PR-863/7 is complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #862