This repository has been archived by the owner on Jan 15, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 538
[MODEL][API] Change BaseTransformerEncoder to HybridBlock #845
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #845 +/- ##
=========================================
Coverage ? 79.65%
=========================================
Files ? 66
Lines ? 6379
Branches ? 0
=========================================
Hits ? 5081
Misses ? 1298
Partials ? 0
|
Codecov Report
|
leezu
reviewed
Jul 24, 2019
eric-haibin-lin
changed the title
[WIP][MODEL] Change BaseTransformerEncoder to HybridBlock
[MODEL] Change BaseTransformerEncoder to HybridBlock
Aug 5, 2019
We can limit this PR to hybridize transformer encoder only. I can take care of the hybridization of BERTModel and the export script in a separate PR. |
eric-haibin-lin
changed the title
[MODEL] Change BaseTransformerEncoder to HybridBlock
[MODEL][API] Change BaseTransformerEncoder to HybridBlock
Aug 5, 2019
Thank you for working on this, @eric-haibin-lin . Sure, we can change the export script in another PR. |
This reverts commit d024a0c.
Fixed by #877 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR intends to change the BaseTransformerEncoder to HybridBlock so we can export it without padding to fixed sequence length.
#789
TODOs:
Checklist
Essentials
Changes
Comments