This repository was archived by the owner on Jan 15, 2024. It is now read-only.
Merged
Conversation
For example, "." is not allowed to occur in a jobName. As jobName is typically based on branch name in our setup, "." may occur in the requested jobName leading to failure. With this commit, all disallowed characters are simply removed.
Codecov Report
|
1 similar comment
Codecov Report
|
Member
Member
|
Job PR-836/1 is complete. |
5 tasks
Member
Member
|
Job PR-836/2 is complete. |
Member
Member
|
Job PR-836/3 is complete. |
szha
approved these changes
Jul 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For example, "." is not allowed to occur in a jobName. As jobName is typically
based on branch name in our setup, "." may occur in the requested jobName
leading to failure. With this commit, all disallowed characters are simply
removed from the jobName.