This repository was archived by the owner on Jan 15, 2024. It is now read-only.
[BUGFIX] Fix TokenEmbedding serialization with emb[emb.unknown_token] != 0#763
Merged
szha merged 2 commits intodmlc:masterfrom Jun 13, 2019
Merged
[BUGFIX] Fix TokenEmbedding serialization with emb[emb.unknown_token] != 0#763szha merged 2 commits intodmlc:masterfrom
emb[emb.unknown_token] != 0#763szha merged 2 commits intodmlc:masterfrom
Conversation
Codecov Report
|
Codecov Report
@@ Coverage Diff @@
## master #763 +/- ##
=========================================
Coverage ? 90.59%
=========================================
Files ? 64
Lines ? 6112
Branches ? 0
=========================================
Hits ? 5537
Misses ? 575
Partials ? 0
|
Member
|
Job PR-763/1 is complete. |
Member
|
Job PR-763/2 is complete. |
szha
approved these changes
Jun 11, 2019
Member
|
Job PR-763/3 is complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up on #750. #750 forgot to remove one leftover assertion, preventing serialization of TokenEmbedding with
emb[emb.unknown_token] != 0.Checklist
Essentials