Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

[WIP] filter API #741

Closed
wants to merge 4 commits into from
Closed

Conversation

eric-haibin-lin
Copy link
Member

Description

(Brief description on what this PR is about)

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@codecov
Copy link

codecov bot commented Jun 1, 2019

Codecov Report

❗ No coverage uploaded for pull request head (filter@7c6c713). Click here to learn what that means.
The diff coverage is n/a.

@codecov
Copy link

codecov bot commented Jun 1, 2019

Codecov Report

❗ No coverage uploaded for pull request head (filter@5a000eb). Click here to learn what that means.
The diff coverage is n/a.

@szha szha requested a review from leezu June 1, 2019 05:25
@leezu
Copy link
Contributor

leezu commented Jun 3, 2019

Thanks @eric-haibin-lin. I added a small change to explicitly test against None instead of taking the boolean value only: 5a000eb

@eric-haibin-lin
Copy link
Member Author

moved to apache/mxnet#16078

@eric-haibin-lin eric-haibin-lin deleted the filter branch February 2, 2020 06:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants