-
Notifications
You must be signed in to change notification settings - Fork 538
[enhancement] refactor bert finetuning script #692
Conversation
@Gpwner here is the fix for the BERTTransform bug. Thanks for reporting |
Codecov Report
@@ Coverage Diff @@
## master #692 +/- ##
========================================
Coverage ? 89.4%
========================================
Files ? 66
Lines ? 5918
Branches ? 0
========================================
Hits ? 5291
Misses ? 627
Partials ? 0
|
Codecov Report
@@ Coverage Diff @@
## master #692 +/- ##
=========================================
Coverage ? 90.94%
=========================================
Files ? 64
Lines ? 5887
Branches ? 0
=========================================
Hits ? 5354
Misses ? 533
Partials ? 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff, looks worthwhile! I've hacked in a couple of these features myself downstream (mp for the BERTDatasetTransform and GPU selection).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Job PR-692/10 is complete. |
* refactor finetune script * fix test with inference_only * enhance data preprocessing * fix label in bert transform * fix lint * fix lint * Update dataset.py * fix test * fix test * do not use bert-adam on mxnet 1.4 * use sys.executable * fix tutorial * parameter test * fix typo * commit a missing line
I try the new script, and found the error:
|
@pengxin99 you may need to install GluonNLP from master branch first. http://gluon-nlp.mxnet.io/install.html#install-from-github |
@pengxin99 would you mind sending me the complete command to reproduce it? |
@szha Thanks and i think i run the script at the latest gluonnlp(use python setup.py install) @eric-haibin-lin I list the env and run command below: finetune: |
I use the #708 to have a try, and it works well :) |
* refactor finetune script * fix test with inference_only * enhance data preprocessing * fix label in bert transform * fix lint * fix lint * Update dataset.py * fix test * fix test * do not use bert-adam on mxnet 1.4 * use sys.executable * fix tutorial * parameter test * fix typo * commit a missing line
Description
summary of changes:
Checklist
Essentials
Changes
Comments