This repository has been archived by the owner on Jan 15, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change introduces sorting of chunks before executing evaluation to reduce padding to minimum and in this way improve performance.
How the change works
As every input feature has unique qas_id it can be used for sorting. With the sorting evaluation function goes like this:
Step number 1 is performed so that chunks and their inference results can be easily put in proper order in step number 5 for evaluation in step 6.
Performance
Results for max_seq_length=128, doc_stride=32:
no sort:
sorted:
Performance did not improve much due to most of the chunks being of same 128 length due to relatively small values of max_seq_length and doc_stride.
Results for max_seq_length=512, doc_stride=128 (default values in run_squad.py script):
no sort:
sorted:
As you can see the performance improved significantly (~20%) without any loss of accuracy.
cc @dmlc/gluon-nlp-team