This repository has been archived by the owner on Jan 15, 2024. It is now read-only.
[CI] Update GPU Test Workflow + Update Some Tests and README #1316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1316 +/- ##
=======================================
Coverage 84.45% 84.45%
=======================================
Files 42 42
Lines 6426 6426
=======================================
Hits 5427 5427
Misses 999 999
Continue to review full report at Codecov.
|
sxjscience
reviewed
Aug 26, 2020
.github/workflows/unittests-gpu.yml
Outdated
| @@ -38,9 +38,6 @@ jobs: | |||
|
|
|||
| - name: Test project on AWS Batch | |||
| run: | | |||
| python ./tools/batch/submit-job.py --region us-east-1 --job-type p3.2x --source-ref ${{ github.ref }} --work-dir tools/batch --remote https://github.com/dmlc/gluon-nlp --command "./test.sh" --wait | |||
| python ./tools/batch/submit-job.py --region us-east-1 --job-type p3.2x --source-ref ${{ github.ref }} --work-dir tools/batch --remote https://github.com/dmlc/gluon-nlp --command "../../test.sh" --wait | tee > script.log | |||
|
|
|||
There was a problem hiding this comment.
Is there a way to manually upload the coverage in AWS Batch?
| cfg.MODEL.num_heads = 2 | ||
| cfg.MODEL.compute_layout = compute_layout | ||
| cfg.freeze() | ||
| def test_bert_small_cfg(compute_layout, ctx): |
There was a problem hiding this comment.
There was a problem hiding this comment.
Yes. We can use this like mx.context._current.set(mx.Context('gpu',0)) without with statement.
There was a problem hiding this comment.
This is an internal API and may change in the future. It may be better to use the with statement inside the conftest.py
szha
reviewed
Aug 26, 2020
test.sh
Outdated
| python3 -m pip install --upgrade --quiet cython | ||
| python3 -m pip install --pre --user --quiet "mxnet-cu102>=2.0.0b20200802" -f https://dist.mxnet.io/python | ||
| python3 -m pip install --user --quiet -e .[extras] | ||
| python3 -m pytest --cov=./ --cov-report=xml --durations=50 --device="gpu" ../../tests/ |
There was a problem hiding this comment.
this script is already at the root level and looking in paths further up would be confusing.
sxjscience
reviewed
Aug 27, 2020
test.sh
Outdated
| @@ -3,10 +3,12 @@ | |||
|
|
|||
| # alias python3='/usr/bin/python3' | |||
sxjscience
previously requested changes
Aug 27, 2020
.github/workflows/unittests-gpu.yml
Outdated
| @@ -38,9 +38,6 @@ jobs: | |||
|
|
|||
| - name: Test project on AWS Batch | |||
| run: | | |||
| python ./tools/batch/submit-job.py --region us-east-1 --job-type p3.2x --source-ref ${{ github.ref }} --work-dir tools/batch --remote https://github.com/dmlc/gluon-nlp --command "./test.sh" --wait | |||
| python ./tools/batch/submit-job.py --region us-east-1 --job-type p3.2x --source-ref ${{ github.ref }} --work-dir tools/batch --remote https://github.com/dmlc/gluon-nlp --command "../../test.sh" --wait | tee > script.log | |||
|
|
|||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Essentials
Changes
Comments
cc @dmlc/gluon-nlp-team