Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

minor fix for run_electra.py & remove hybridization in the construction method #1307

Merged
merged 1 commit into from
Aug 22, 2020
Merged

minor fix for run_electra.py & remove hybridization in the construction method #1307

merged 1 commit into from
Aug 22, 2020

Conversation

ZiyueHuang
Copy link
Member

Description

model.collect_params() returns a python dict. @sxjscience

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

cc @dmlc/gluon-nlp-team

@ZiyueHuang ZiyueHuang requested a review from a team as a code owner August 21, 2020 12:52
@sxjscience
Copy link
Member

I'll merge first, need to fix the dockerhub check.

@sxjscience sxjscience merged commit d17ec4c into dmlc:master Aug 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sxjscience sxjscience sxjscience approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZiyueHuang @sxjscience