Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

fix prepare_openwebtext #1289

Merged
merged 1 commit into from
Aug 6, 2020
Merged

fix prepare_openwebtext #1289

merged 1 commit into from
Aug 6, 2020

Conversation

ZiyueHuang
Copy link
Member

@ZiyueHuang ZiyueHuang commented Aug 6, 2020

Description

The current implementation will raise TypeError: 'NoneType' object is not iterable, since random.shuffle() shuffles the input in place and returns None.

cc @szhengac @sxjscience

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

cc @dmlc/gluon-nlp-team

@codecov
Copy link

codecov bot commented Aug 6, 2020

Codecov Report

Merging #1289 into numpy will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            numpy    #1289   +/-   ##
=======================================
  Coverage   83.60%   83.60%           
=======================================
  Files          42       42           
  Lines        6375     6375           
=======================================
  Hits         5330     5330           
  Misses       1045     1045           

@sxjscience sxjscience merged commit ded0f99 into dmlc:numpy Aug 6, 2020
@zheyuye
Copy link
Member

zheyuye commented Aug 7, 2020

Thanks for fixing this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants