Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

Fix layer_norm_eps in BERTEncoder #1215

Merged
merged 1 commit into from
May 1, 2020
Merged

Fix layer_norm_eps in BERTEncoder #1215

merged 1 commit into from
May 1, 2020

Conversation

leezu
Copy link
Contributor

@leezu leezu commented Apr 30, 2020

@leezu leezu requested a review from a team as a code owner April 30, 2020 07:25
@mli
Copy link
Member

mli commented Apr 30, 2020

Job PR-1215/1 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1215/1/index.html

@codecov
Copy link

codecov bot commented May 1, 2020 •
edited
Loading

Codecov Report

Merging #1215 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1215   +/-   ##
=======================================
  Coverage   87.42%   87.42%           
=======================================
  Files          81       81           
  Lines        7346     7347    +1     
=======================================
+ Hits         6422     6423    +1     
  Misses        924      924
Impacted Files Coverage Δ
src/gluonnlp/model/bert.py 94.64% <100.00%> (+0.01%) ⬆️

@leezu leezu merged commit 425f799 into dmlc:master May 1, 2020
@leezu leezu deleted the fixlayernorm branch May 1, 2020 04:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eric-haibin-lin eric-haibin-lin eric-haibin-lin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leezu @mli @eric-haibin-lin