Revert copy-constructor modification which causes TVM segfaults #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It might be better to consider upgrading to C++17 ? Is this option being considered? |
|
we could do that, but i think we prefer to be able compile |
areusch
force-pushed
the
revert-copy-constructor
branch
from
15a64f6
to
57f9db9
Compare
|
:/ it seems the dmlc-core CI is busted |
tqchen
approved these changes
Apr 29, 2022
|
Merged since the hotfix is important to make sure optional function correctly(for non-POD types) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #658
Unfortunately I don't have any more information on why this happens, but tvm is now blocked in updating dmlc-core. I had a unittest that could pass previously, but didn't pass after #658--but, a) I unfortunately lost it in auto-updating a submodule b) don't know if that was really the problem because most of these single-arg constructors aren't marked explicit.
cc @tqchen @mozga-intel @szha