Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3's: avoid %-formatting, f-strings as a new way #661

Merged
merged 2 commits into from
Sep 21, 2021

Conversation

mozga-intel
Copy link
Contributor

@mozga-intel mozga-intel commented Sep 20, 2021

Python 3's f-Strings: An Improved String Formatting Syntax; Issue comes from: #658

CI jobs fail because %-formatting is obsolete: an error message:

+ make lint
scripts/lint.py dmlc "all" include src scripts --exclude_path include/dmlc/concurrentqueue.h include/dmlc/blockingconcurrentqueue.h
************* Module lint
 scripts/lint.py:42: convention (C0209, consider-using-f-string, LintHelper._print_summary_map) Formatting a regular string which could be a f-string
 scripts/lint.py:46: convention (C0209, consider-using-f-string, LintHelper._print_summary_map) Formatting a regular string which could be a f-string
 scripts/lint.py:114: convention (C0209, consider-using-f-string, LintHelper.print_summary) Formatting a regular string which could be a f-string

@szha szha requested a review from hcho3 September 20, 2021 20:07
@szha szha merged commit cd3d935 into dmlc:main Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants