Remove throw spec from omp.h for clang #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I suspect the memory error is due to race condition |
|
@hcho3 in CI ? |
|
@larroy Yes, the memory error you can see in Travis CI is intermittent |
|
@hcho3 can we merge this? I need it for an MXNet PR. |
|
Merging this for now. I'll create a new issue about failing tests for dmlc_exception and std_exception. |
|
seems it's not failing due to double free anymore. |
|
@larroy should this be |
|
I think the intention was to fix it for Android only, when using clang, hence &&, don't remember the details. But see that we are compiling with Clang in CI for a while, why did it start failing now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes compilation with OMP using the Clang compiler.