Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installation paths and refactor #528

Merged
merged 1 commit into from
May 2, 2019
Merged

Fix installation paths and refactor #528

merged 1 commit into from
May 2, 2019

Conversation

sl1pkn07
Copy link
Contributor

@sl1pkn07 sl1pkn07 commented Apr 29, 2019

downstream bug: apache/mxnet#14692 (review)

  • Added option to install documentation with -DINSTALL_DOCUMENTATION=ON (OFF by default)
  • Refactored and remove duplicate code about headers & docs installation rules
  • Install the headers and the docs following the GNU standard installation directories

@hcho3
Copy link
Contributor

hcho3 commented Apr 30, 2019

@larroy Can you review?

@hcho3 hcho3 requested a review from trivialfis April 30, 2019 18:18
@larroy
Copy link
Contributor

larroy commented Apr 30, 2019

See my comment in your PR in mxnet. I think we are almost there, but there are errors when I try both PRs together.

@sl1pkn07
Copy link
Contributor Author

sl1pkn07 commented Apr 30, 2019

thats seems is because needs update dmlc-core submodule into mxnet, pointed to updated dmlc-core with this pr applied

@larroy
Copy link
Contributor

larroy commented May 1, 2019

I did that, it failed. Could you submit a PR with the gitmodule directed to your repo so I can just clone and test?

@sl1pkn07
Copy link
Contributor Author

sl1pkn07 commented May 2, 2019

i'm not sure if i do the things ok, but try: https://github.com/sl1pkn07/incubator-mxnet

@larroy
Copy link
Contributor

larroy commented May 2, 2019

thanks. Your TVM commit is too new, I checked out the same revision as in master: 0f053c82a747b4dcdf49570ec87c17e0067b7439 The newest TVM requires changes that are not yet merged to mxnet master.

@larroy
Copy link
Contributor

larroy commented May 2, 2019

This works. Let's get the prs merged. Thanks a lot!

@hcho3 hcho3 merged commit ee50e93 into dmlc:master May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants