Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support INF and NAN in locale-independent dmlc::strtof #508

Merged
merged 2 commits into from
Mar 3, 2019
Merged

Support INF and NAN in locale-independent dmlc::strtof #508

merged 2 commits into from
Mar 3, 2019

Conversation

hcho3
Copy link
Contributor

@hcho3 hcho3 commented Mar 3, 2019

Fixes #503.

@hcho3 hcho3 requested a review from szha March 3, 2019 02:32
szha
szha reviewed Mar 3, 2019
View reviewed changes
test/unittest/unittest_param.cc
kwargs["float_param"] = "infinity war";
ASSERT_THROW(param.Init(kwargs), dmlc::ParamError);
kwargs["float_param"] = "Nanny";
ASSERT_THROW(param.Init(kwargs), dmlc::ParamError);
Copy link
Member

@szha szha Mar 3, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄 🤦‍♂️ you took it really far!

@szha szha merged commit 7e2a1ec into dmlc:master Mar 3, 2019
@hcho3 hcho3 deleted the support_inf_nan branch March 3, 2019 04:01
@hcho3 hcho3 mentioned this pull request May 7, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szha szha szha left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hcho3 @szha