-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dmlc::strtof() #481
Merged
Merged
Fix dmlc::strtof() #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@trivialfis I've removed platform-dependent code for the sake of future maintenance burden. |
TODO. Add docstrings for all public functions in |
Works fine, thank you. |
It turns out |
ruslo
pushed a commit
to hunter-packages/dmlc-core
that referenced
this pull request
Mar 23, 2019
* Move strtonum.h to include/ * Implement range checking into dmlc::strtof(); add dmlc::strtod() * Fix build * More example of locale-independent parsing * Add docstrings; rename functions * Implement stof(), stod(); add extra check to FieldEntry<float>, FieldEntry<double> * Fix lint * Clearly document limitations * Make types explicit * Throw error when given too many digits before the decimal point * handle edge case where exponent is exactly kMaxExponent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous implementation of locale-independent parsing (#455) was faulty:
This PR rectifies the situation by re-using existing implementation of
strtof()
. In particular,dmlc::data::strtof()
is moved toinclude/
directory.strtof()
implementation to add range checking and to implementdmlc::strtod()
.Also, the locale functions have been removed.
Closes #478.