-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] [DeviceType] Add support for MAIA #120
Conversation
Thanks @kyule7 . Would like to get a bit more background on about this device type, is there any public available information that describes the proposed device? |
I do not think there is any good public information about the device, so it is difficult to describe any background and details about it at the moment. Would extending DLDeviceType require any public knowledge about the device? |
@kyule7 usually yes, since one goal of DLPack to be stable and widely used, so we would like to maintain a list of public available devices for that purpose. DLExtDevice would serve as a good middle ground for plug in less mature device requirements |
I used DLExtDevice for experiment with a new device for functionality, and planned to extend dlpack first in order to extend the dependent frameworks for the device support. I will close this PR since I do not think any public information about the device is available currently. |
thanks @kyule7 you are more than welcome to bring up followups once it is publicly available |
Reopening it since Maia 100 is publicly announced. |
include/dlpack/dlpack.h
Outdated
@@ -116,6 +116,8 @@ typedef enum { | |||
kDLWebGPU = 15, | |||
/*! \brief Qualcomm Hexagon DSP */ | |||
kDLHexagon = 16, | |||
/*! \brief Microsoft NPU */ | |||
kDLMsNpu = 17, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should it be kDLMSNPU? just to followup other convention for abbrev
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renamed it to kDLMAIA since the MAIA is the released name.
gentle ping @kyule7 :) |
Could anyone help merging this PR? |
Thanks @kyule7 this is now merged |
@tqchen worth to release ? |
There're a few changes from the Array API side that we're wrapping up, would be nice to hold off a bit 🙂 |
btw I noticed the doc build CI has been failing for some time (perhaps before this PR). Fixing it in #136. |
@edgarriba Would like to apply this change in the dependent framework repos (pytorch and onnxruntime), would there be any chance to have a new release including this PR change? |
Hi, v1.0rc is out a few days ago, could you give it a try? |
This PR extends
DLDeviceType
to support Microsoft MAIA devices.