Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CUDA] Update CCCL to 2.3.0 #7171

Merged
merged 4 commits into from
Feb 29, 2024
Merged

Conversation

mfbalin
Copy link
Collaborator

@mfbalin mfbalin commented Feb 28, 2024

Description

Update to latest CCCL for best performance. With this release, we don't need to set the DTHRUST_CUB_WRAPPED_NAMESPACE macro anymore. For details, see release notes: https://github.com/NVIDIA/cccl/releases/tag/v2.3.0 (Linkage Issues section) and PR: NVIDIA/cccl#443

CCCL release notes say: "As of the 2.3 release, linkage issues are addressed by default without the need for THRUST_CUB_WRAPPED_NAMESPACE."

Let's land this PR for DGL 2.1.

One concern was that lintrunner and the other linter for the CPP sources in the CI disagree about the placement of the cub include. That is why I had to place // NO_LINT comments in 4 of the files.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@mfbalin mfbalin requested a review from Rhett-Ying February 28, 2024 18:47
@dgl-bot
Copy link
Collaborator

dgl-bot commented Feb 28, 2024

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@dgl-bot
Copy link
Collaborator

dgl-bot commented Feb 28, 2024

Commit ID: 27449f7

Build ID: 1

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Feb 28, 2024

Commit ID: 8d8f43e

Build ID: 2

Status: ❌ CI test failed in Stage [Lint Check].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Feb 28, 2024

Commit ID: 013462a

Build ID: 3

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@mfbalin mfbalin requested a review from TristonC February 28, 2024 19:28
@dgl-bot
Copy link
Collaborator

dgl-bot commented Feb 28, 2024

Commit ID: 2105cf1

Build ID: 4

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@frozenbugs frozenbugs added the Release Blocker Issues that blocks release label Feb 29, 2024
@dgl-bot
Copy link
Collaborator

dgl-bot commented Feb 29, 2024

Commit ID: 167412f4443b789f4d66d350f97d398c6f1e140e

Build ID: 5

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@mfbalin mfbalin merged commit 73e01d6 into dmlc:master Feb 29, 2024
2 checks passed
@mfbalin mfbalin deleted the gb_update_cccl_to_2.3.0 branch February 29, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release Blocker Issues that blocks release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants