Fix NaN total L1 fees #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hesom is attempting to deploy a commit to the ETH Burned Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm getting NaN value in the "Total" row in L1 Security Costs tab. The main reason is the NaN value inside the result of the data prop of L1List. I fixed this by simply adding 0 to the total if the result is invalid.
I think the reason for the NaN is an error in the API call that is supposed to get the DeversiFi fees. This causes the results of the children of StarkNet in the bundleItems function to not be added correctly. I fixed this similarly by just adding 0 if the current result is invalid.