Skip to content

Commit

Permalink
Revert change for windows cert pool access in 1.8
Browse files Browse the repository at this point in the history
The upstream change to allow access to the windows system
cert pool was reverted, reverting and updating messaging.
Maybe 1.9....golang/go#18609

Signed-off-by: Derek McGowan <[email protected]> (github: dmcgowan)
  • Loading branch information
dmcgowan committed Feb 3, 2017
1 parent c972f11 commit f652133
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 12 deletions.
2 changes: 1 addition & 1 deletion tlsconfig/certpool_go17.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// +build go1.7,!go1.8
// +build go1.7

package tlsconfig

Expand Down
10 changes: 0 additions & 10 deletions tlsconfig/certpool_go18.go

This file was deleted.

2 changes: 1 addition & 1 deletion tlsconfig/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ func Server(options Options) (*tls.Config, error) {
return nil, fmt.Errorf("Error reading X509 key pair (cert: %q, key: %q): %v. Make sure the key is not encrypted.", options.CertFile, options.KeyFile, err)
}
tlsConfig.Certificates = []tls.Certificate{tlsCert}
if options.ClientAuth >= tls.VerifyClientCertIfGiven {
if options.ClientAuth >= tls.VerifyClientCertIfGiven && options.CAFile != "" {
CAs, err := certPool(options.CAFile)
if err != nil {
return nil, err
Expand Down

0 comments on commit f652133

Please sign in to comment.