Allow Setting for Host DNS Entries#382
Merged
MalloZup merged 1 commit intodmacvicar:masterfrom Sep 6, 2018
Merged
Conversation
Contributor
Author
|
this also includes the DNS rework from #376 |
eparis
force-pushed
the
crawford-host-dns
branch
from
13bfccc to
f109aa0
Compare
MalloZup
reviewed
Aug 29, 2018
libvirt/resource_libvirt_network.go
Outdated
| // ... | ||
| // } | ||
| // | ||
| func datasourceLibvirtNetworkDNSHostTemplate() *schema.Resource { |
Collaborator
There was a problem hiding this comment.
i am thinking that if we introduce a datasource resource, would make sense to me to create a new file
as example:
data_source_libvirt_network_dns..
https://github.com/terraform-providers/terraform-provider-aws/blob/master/aws/data_source_aws_acmpca_certificate_authority_test.go
eparis
force-pushed
the
crawford-host-dns
branch
10 times, most recently
from
9a05cd6 to
652f585
Compare
Contributor
Author
eparis
force-pushed
the
crawford-host-dns
branch
from
652f585 to
3c0a809
Compare
Contributor
Author
|
rebased. thank you! |
eparis
force-pushed
the
crawford-host-dns
branch
2 times, most recently
from
27c5549 to
0bafd91
Compare
The DNS hosts feature allows DNS records to be created that point to a given IP address. This is useful for aliasing as well as setting up round-robin DNS (by creating multiple hosts that point to the same IP address). This creates a new datasource called libvirt_network_dns_hosts_template, which can be used to populate the dns_host attribute in libvirt_network resources. The use of a datasource is required in order to dynamically generate dns_host entries (since 'count' is the only looping construct in Terraform and 'count' is limited to datasources and resources). The list of hostnames has also been replaced by a single hostname with the option of declaring multiple dns_host blocks with the same IP address. I originally tried to externally generate a variable that would host the list of maps needed for the dns_host attribute, but Terraform explicitly disallows lists of maps greater than length one. Instead, I decided to follow the pattern established by template_file and create a resource that can be rendered. The hostnames attribute had to be replaced with hostname because the underlying schema for the 'rendered' attribute is a TypeMap. In Terraform, this is not a generic map, but is instead limited to map[string]string. To accommodate this, multiple dns_host blocks can be defined with the same IP address, one for each hostname.
eparis
force-pushed
the
crawford-host-dns
branch
from
0bafd91 to
a4d0ba6
Compare
Collaborator
|
@eparis i will review it more in deep tomorrow with a fresh mind. sofar looks nice to me but i want to try it out with time. thank you for your patience 👍 |
Contributor
Author
|
@MalloZup Patience? You've been one of the most responsive and helpful maintainers I've ever dealt with! Thank you for helping me get it right. |
dmacvicar
approved these changes
Sep 6, 2018
Collaborator
|
merging. thx @eparis for the contribution! i hope it will be helpful for your projects and c u next contrib 👍 😄 |
Contributor
Author
|
Thank you both, this was great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow one to set host based DNS entries. So I can say
host=host1, ip=1.1.1.1
host=host1, ip=1.1.1.2
host=host2, ip=1.1.1.1
And It would work the way you expect...