[WIP] More configuration options for networks#288
Closed
Conversation
inercia
force-pushed
the
network_improvs
branch
from
6e417f1 to
31b0d58
Compare
inercia
force-pushed
the
network_improvs
branch
from
31b0d58 to
ce90234
Compare
|
I would like to see this also provide options to configure the parameters required for pxe booting. Specifically, the ability to provide a bootp parameter for the dhcp server and a tftp element. Can those be added? I don't mind adding them myself if people are interested. |
Contributor
|
Any hope to get this merged soon? I need to be able to set up private networks without DHCP and DNS servers provided by libvirt. |
Collaborator
|
i am currently splitting this big pr in smaller one, plus checking if it working. currently working on dhcp part one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does some cleanups in the
libvirt_networkblock, adds some sub-blocks likedns {},dhcp {}and includes new attributes likeroutes = []