make network dns enabled by default #1100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://libvirt.org/formatnetwork.html#addressing specifies dns is disabled only if enable="no", but if omitted, it is enabled by default. However, it claims if disabled, it would ignore the dns entries, but in reality it fails with "error: XML error: Extra data in disabled network". This change makes: - if enabled is omitted, we use the libvirt default - we only add dns information to the xml if enabled
dmacvicar
added
Feedback wanted
Important (Wanted)
dmacvicar
added a commit
to jimnydev/terraform-provider-libvirt
that referenced
this pull request
Sep 28, 2024
https://libvirt.org/formatnetwork.html#addressing specifies dns is disabled only if enable="no", but if omitted, it is enabled by default. However, it claims if disabled, it would ignore the dns entries, but in reality it fails with "error: XML error: Extra data in disabled network". This change makes: - if enabled is omitted, we use the libvirt default - we only add dns information to the xml if enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://libvirt.org/formatnetwork.html#addressing specifies dns is disabled only if enable="no", but if omitted, it is enabled by default.
However, it claims if disabled, it would ignore the dns entries, but in reality it fails with "error: XML error: Extra data in disabled network".
terraform-provider-libvirt defaults to enabled=false, and it seems it was accidentally introduced with #969
This change makes:
This also fixes the testacc testsuite, which was failing due to this "error: XML error: Extra data in disabled network" problem.
Fixes #1079