Makes date/time format parameterized #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlwyatt
reviewed
Aug 13, 2017
LogFile.cs
Outdated
| @@ -65,7 +71,7 @@ public override void WriteDebug(string message) | |||
| CheckDirectory(); | |||
| if (message != String.Empty) | |||
| { | |||
| message = String.Format("{0,-29} - [D] {1}", DateTime.UtcNow.ToString(DateTimeFormat), message); | |||
| message = String.Format("{0,-18} - [D] {1}", DateTime.UtcNow.ToString(DateTimeFormat), message); | |||
There was a problem hiding this comment.
Hi Dave! I changed it back to its original value. I was just doing some testing back then. Thanks!
dlwyatt
reviewed
Aug 13, 2017
LogFile.cs
Outdated
| @@ -11,21 +11,25 @@ public class LogFile : HostIOSubscriberBase | |||
| { | |||
| #region Fields | |||
|
|
|||
| private const string DateTimeFormat = "r"; | |||
| //private string DateTimeFormat = "dd-MMM-yyyy - HH:mm:ss"; | |||
There was a problem hiding this comment.
No reason to leave a commented line of code around
|
v1.3.0 with this PR has been published to the PowerShell Gallery, and in a GitHub release. Thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds -DateTimeFormat parameter to Enable-Logfile