Misc enhancements & Bug fix - Progressbars, Rich tables, Coin and Dice probability spaces, Black formatting #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd size of draw is set to None or 1
ksachdeva
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains multiple changes however those changes are in separate commits.
When merging you can either flatten all the changes or pull them all separately.
Here are the changes so far:
a) Bug fix when replacement=False
b) Black formatting (https://black.readthedocs.io/en/stable/)
c) Dice and Coin probability spaces.
d) Display of progress bar when simulating (https://rich.readthedocs.io/en/stable/progress.html)
e) Usage of Rich (https://rich.readthedocs.io/en/stable/tables.html) tables. This IMHO helps not only display more beautiful tables but also helps in not creating custom HTML etc