-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial commit of React frontend #48
Initial commit of React frontend #48
Conversation
To run the new frontend, you can:
|
Screenshot for the change 079fbd1: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tried to run this yet, but my gut reaction is that this seems like so much overkill for what we use the monitor for. We previously talked about getting rid of the monitor, and I have worked to simplify its maintenance and reduce its scope. This seems like heading the opposite direction, with more infrastructure built around maintaining it, to further entrench it in our build, rather than whittle it down and keep it a lightweight thing to maintain.
I realize that my gut reaction may also be driven by my overall lack of familiarity with these things... so I acknowledge that what seems like complexity to me may just be ignorance. Nevertheless, I don't want to completely discount my instinct on this, either. I would like to understand more about the value that is added by making our project become a react web project, before forming a more concrete opinion.
<groupId>com.github.eirslett</groupId> | ||
<artifactId>frontend-maven-plugin</artifactId> | ||
<version>1.15.1</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a big fan of this plugin's downloading and installing npm. What we do for the javascript formatting is just run an external script that runs if npm is already installed. I think using the user's already-installed npm is better. We do the same with thrift... you have to install thrift yourself. For thrift, we put that part in a build profile, so if you don't have thrift installed, it's fine as long as you're not modifying the thrift bits. Here, it seems we could do the same, but perhaps we require this to run every time?
</configuration> | ||
<executions> | ||
<execution> | ||
<id>install node and npm</id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IDs should not have spaces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this is primarily a Java project, not a web project, and because npm is plagued with supply chain issues, I have concerns that we aren't really qualified to maintain these dependencies for this, and keeping this up-to-date and secure with as many dependencies as it brings in, is going to be a burden.
No description provided.