Drop dependency on deprecated `gulp-util` #647

demurgos · 2017-12-27T23:34:43Z

Closes #646

demurgos · 2017-12-28T01:23:16Z

This PR also update the versions tested with CI to match the ones used by Sass itself.
The main difference is that 0.10.0 is no longer tested because Node stopped maintaining it, and most dependencies started to require Node 4+.

xzyfer

Please remove package.lock and yarn.lock files

xzyfer · 2017-12-28T06:24:28Z

.travis.yml

@@ -1,6 +1,7 @@
 language: node_js
 node_js:
-  - "0.10"


Node sass still officiallly supports 0.10, 0.12, and iojs. It's not tested in Travis but is tested locally before releases.

xzyfer · 2017-12-28T06:26:10Z

Thanks. Dropped support for old node versions will require a major version bump. I wasn't planning on bumping the major until node-sass@5 landed. Is it possible to make this work with Node 0.10?

demurgos · 2017-12-28T10:56:32Z

Hi,
Thanks for the info: I did not know that Sass still wants to support these versions. I'll try to find some older versions of the dependencies that support Node 0.10.0. I opened an issue to discuss this change.

Regarding the lockfiles, you are better off by keeping them, especially if you plan to support unmaintained Node versions. The lock files are intended to be committed and have no effect on consumers: they are used for library developers and CI to make sure that you develop with the same working dependencies.
Edit: One concrete example is that I am currently having issues on Travis to compile Sass for iojs, I wouldn't have this issue if a lockfile was already there.

demurgos · 2017-12-28T13:52:04Z

Hi, I am having trouble to make node-sass work with iojs (Node 3). I pinned node-sass to exactly 4.0.0 but its install step has a dependency on request which itself depends on hoek which requires Node 4.

Are you sure node-sass supports versions before Node 4?

(Also, lock files are exactly there for this kind of situation, to avoid a transitive dependency to break everything)

xzyfer · 2017-12-28T13:57:45Z

Correct. The latest release 4.7.2 pinned to a version on request that still supported old node. Unfortunately that release has issues with iojs v3 so I'm ok with not testing iojs in ci.

…

On 29 Dec. 2017 12:52 am, "Charles Samborski" ***@***.***> wrote: Hi, I am having trouble to make node-sass work with iojs (Node 3). I pinned node-sass to exactly 4.2.0 but its install step has a dependency on request which itself depends on hoek which requires Node 4. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#647 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAjZWDYXqzAnfJmwiQpDM3CZb0-pneesks5tE50EgaJpZM4RN4zD> .

demurgos · 2017-12-28T14:29:51Z

@xzyfer
I tried my best to support it but at the moment, the best would be to merge #649 first, it's just going to cause more issues.
You are effectively asking me to drop support for iojs, so it's better to do it properly in its own PR and then come back to this issue.

Even if this Node issue is not related to gulp-util, it should be fixed first. Please also note that dropping gulp-util is important because it is causing build issues with the latest release of Gulp 4. You are not the first person I am contacting to patch this and multiple other packages have similar issues were old versions of Node are wrecking havoc the builds because they weren't touched in a year but most dependencies have moved on. We reached a point were not keeping dependencies up-to-date is causing builds to break so I'd really like to have it sorted as fast as possible. Thanks for your support :)

demurgos · 2017-12-29T17:37:45Z

I was wrong about lock files for libraries (they may have hidden issues with the transitive dependencies, it's better to have them break early), I'll remove them.
Still, please consider migrating to newer Node versions and dropping gulp-util.

Closes dlmanning#648

Closes dlmanning#646

demurgos · 2018-01-11T22:16:11Z

@xzyfer @dlmanning
Any news about this PR? gulp-sass is one of the most popular gulp plugins so it is important to keep its dependencies up-to-date.

demurgos · 2018-01-26T23:28:03Z

@xzyfer @dlmanning
Are you looking for maintainers? We're currently discussing in the Gulp team to eventually create an org for popular plugins so we'd be able to help with this kind of maintenance.

xzyfer · 2018-01-27T02:36:56Z

We're happy to do it. We're just juggling release timelines for gulp-sass, node-sass, and LibSass so that we're not leaving users behind with new features landing in node-sass. Dropping Node < 4 support is massive breaking change for us that requires some coordination.

…

On 27 Jan. 2018 10:28 am, "Charles Samborski" ***@***.***> wrote: @xzyfer <https://github.com/xzyfer> @dlmanning <https://github.com/dlmanning> Are you looking for maintainers? We're currently discussing in the Gulp team to eventually create an org for popular plugins so we'd be able to help with this kind of maintenance. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#647 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAjZWL3Do0wUSQwdghmNxRAyODt6K1Fkks5tOl-EgaJpZM4RN4zD> .

betorobson · 2018-02-06T13:42:09Z

hi, any update about this PR?

xzyfer · 2018-02-06T22:01:24Z

No. Any updates would appear on this issue.

…

On 7 Feb. 2018 12:42 am, "Roberto Robson" ***@***.***> wrote: hi, any update about this PR? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#647 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAjZWHh3pxlNOQjYWGBNuQD91ELTAXCdks5tSFaxgaJpZM4RN4zD> .

dima-takoy-zz · 2018-02-10T22:42:19Z

@xzyfer will it be fixed after 5 years (now) or we just wait node 4 EOL?

johnturingan · 2018-02-26T09:35:33Z

@xzyfer @dlmanning any luck on merging this PR? :(

xzyfer · 2018-03-11T05:38:48Z

Looks like there are a couple separate breaking changes that'll land soonish.

rejas · 2018-03-26T08:09:04Z

any news if this will get merged or if a new PR to fix the merge conflicts is necessary, @demurgos @xzyfer @dlmanning ?

xzyfer · 2018-03-26T08:10:57Z

There is linked pr that includes these changes and more and a checklist for when it merged.

…

On Mon., 26 Mar. 2018, 7:09 pm Veeck, ***@***.***> wrote: any news if this will get merged or if a new PR to fix the merge conflicts is necessary, @demurgos <https://github.com/demurgos> @xzyfer <https://github.com/xzyfer> @dlmanning <https://github.com/dlmanning> ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#647 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAjZWKHEuBVQptqdANYb5bt8eGYjTtkQks5tiKIggaJpZM4RN4zD> .

xzyfer · 2018-03-26T08:11:52Z

Thanks heaps, this has been included in #667

demurgos changed the title ~~Issue 646~~ Drop dependency on deprecated gulp-util Dec 27, 2017

demurgos force-pushed the issue-646 branch 4 times, most recently from 17b597b to 467d580 Compare December 28, 2017 01:21

xzyfer reviewed Dec 28, 2017

View reviewed changes

demurgos mentioned this pull request Dec 28, 2017

Consider dropping support for unmaintained Node versions #648

Closed

demurgos mentioned this pull request Dec 28, 2017

Ecosystem migration gulpjs/gulp-util#143

Closed

demurgos added 2 commits December 29, 2017 18:39

⬆️ Require Node 4+

9f35160

Closes dlmanning#648

Drop dependency on deprecated gulp-util

6fc7fce

Closes dlmanning#646

demurgos force-pushed the issue-646 branch from 467d580 to 6fc7fce Compare December 29, 2017 17:42

Repository owner deleted a comment from dima-takoy-zz Feb 10, 2018

xzyfer force-pushed the master branch 3 times, most recently from 4059a62 to 856294c Compare March 11, 2018 05:04

xzyfer force-pushed the master branch 10 times, most recently from 5c3ead2 to cc4ed2f Compare March 11, 2018 05:37

xzyfer mentioned this pull request Mar 11, 2018

Drop support for non-Active LTS and Current releases #667

Merged

6 tasks

xzyfer closed this Mar 26, 2018

Drop dependency on deprecated gulp-util #647

Drop dependency on deprecated gulp-util #647

Uh oh!

Conversation

demurgos commented Dec 27, 2017

Uh oh!

demurgos commented Dec 28, 2017

Uh oh!

xzyfer left a comment

Choose a reason for hiding this comment

Uh oh!

xzyfer Dec 28, 2017

Choose a reason for hiding this comment

Uh oh!

xzyfer commented Dec 28, 2017

Uh oh!

demurgos commented Dec 28, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

demurgos commented Dec 28, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xzyfer commented Dec 28, 2017 via email

Uh oh!

demurgos commented Dec 28, 2017

Uh oh!

demurgos commented Dec 29, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

demurgos commented Jan 11, 2018

Uh oh!

demurgos commented Jan 26, 2018

Uh oh!

xzyfer commented Jan 27, 2018 via email

Uh oh!

betorobson commented Feb 6, 2018

Uh oh!

xzyfer commented Feb 6, 2018 via email

Uh oh!

dima-takoy-zz commented Feb 10, 2018

Uh oh!

johnturingan commented Feb 26, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xzyfer commented Mar 11, 2018

Uh oh!

rejas commented Mar 26, 2018

Uh oh!

xzyfer commented Mar 26, 2018 via email

Uh oh!

xzyfer commented Mar 26, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Drop dependency on deprecated `gulp-util` #647

Drop dependency on deprecated `gulp-util` #647

demurgos commented Dec 28, 2017 •

edited

Loading

demurgos commented Dec 28, 2017 •

edited

Loading

demurgos commented Dec 29, 2017 •

edited

Loading

johnturingan commented Feb 26, 2018 •

edited

Loading