Skip to content

Commit

Permalink
pwm: pwm-tipwmss: Remove all pm_runtime gets and puts from the driver
Browse files Browse the repository at this point in the history
Remove all pm_runtime gets and puts, and dummy pm_ops, from the
pwm-tipwmss driver as there is no direct hardware access. The runtime PM
needs to be enabled, so that the runtime PM framework takes care of
enabling/disabling of PWMSS clock when submodules of PWMSS (ECAP or
EHRPWM) call pm_runtime APIs. With this change PWMSS clock goes to
idle when none of the submodules are in use.

Signed-off-by: Jyri Sarha <[email protected]>
Tested-by: Dave Gerlach <[email protected]>
Signed-off-by: Vignesh R <[email protected]>
Signed-off-by: Sekhar Nori <[email protected]>
  • Loading branch information
Jyri Sarha authored and nsekhar committed Aug 8, 2016
1 parent e369b7f commit b2f388a
Showing 1 changed file with 0 additions and 19 deletions.
19 changes: 0 additions & 19 deletions drivers/pwm/pwm-tipwmss.c
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ static int pwmss_probe(struct platform_device *pdev)
struct device_node *node = pdev->dev.of_node;

pm_runtime_enable(&pdev->dev);
pm_runtime_get_sync(&pdev->dev);

/* Populate all the child nodes here... */
ret = of_platform_populate(node, NULL, NULL, &pdev->dev);
Expand All @@ -46,31 +45,13 @@ static int pwmss_probe(struct platform_device *pdev)

static int pwmss_remove(struct platform_device *pdev)
{
pm_runtime_put_sync(&pdev->dev);
pm_runtime_disable(&pdev->dev);
return 0;
}

#ifdef CONFIG_PM_SLEEP
static int pwmss_suspend(struct device *dev)
{
pm_runtime_put_sync(dev);
return 0;
}

static int pwmss_resume(struct device *dev)
{
pm_runtime_get_sync(dev);
return 0;
}
#endif

static SIMPLE_DEV_PM_OPS(pwmss_pm_ops, pwmss_suspend, pwmss_resume);

static struct platform_driver pwmss_driver = {
.driver = {
.name = "pwmss",
.pm = &pwmss_pm_ops,
.of_match_table = pwmss_of_match,
},
.probe = pwmss_probe,
Expand Down

0 comments on commit b2f388a

Please sign in to comment.